[PATCH] D32500: Optimize ItaniumDemangle by using an arena allocator

[Scott Smith via Phabricator via llvm-commits]

scott.smith added inline comments.


================
Comment at: lib/Demangle/ItaniumDemangle.cpp:49-50
+
+static __thread arena * thread_arena = nullptr;
+
+class arena {
----------------
davide wrote:
> I'm not sure this will work with MSVC.
The admittedly non-portable extension works on MSVC, gcc, and clang.  So it's mostly portable ;-)  But it's a hack, I admit.

Though I would prefer to remove plus the arena through to all the callsites.  It would make the diff less readable, so I thought I'd start with this version.  Sorry I should have made that clear from the beginning.



Repository:
  rL LLVM

https://reviews.llvm.org/D32500