[PATCH] D32464: LivePhysRegs: Fix addLiveOutsNoPristines() for return blocks past PEI

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added inline comments.


================
Comment at: lib/CodeGen/LivePhysRegs.cpp:194
+    }
+  }
 }
----------------
MatzeB wrote:
> timshen wrote:
> > If MBB is empty but not a return block, is it the intended behavior here?
> Callee save register only need to be maintained when we actually leave the function.
> Having succ_empty() but not a return block only happens in instance where we are not leaving the function: unreachable statements or calls to noreturn functions such as exit or abort are typical examples we don't need to restore CSRs for that.
I should have said "not returning from the function" instead of "not leaving the function".


Repository:
  rL LLVM

https://reviews.llvm.org/D32464