[PATCH] D32473: [MSP430] Fix PR32769: Select8 and Select16 need to have SR in Uses.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 11:32:58 PDT 2017


efriedma added a comment.

Looks fine, but someone who knows the MSP430 backend better should look at this.



================
Comment at: lib/Target/MSP430/MSP430InstrInfo.td:125
 let usesCustomInserter = 1 in {
+  // SR is marked as used to prevent CMPs from appearing dead.
+  let Uses = [SR] in {
----------------
Not sure this comment adds anything.


https://reviews.llvm.org/D32473





More information about the llvm-commits mailing list