[PATCH] D32466: [llvm-objdump] Don't attempt to print lines beyond the end of file

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 25 10:27:48 PDT 2017


davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

Do me a favour and check that the output is the same of `GNU objdump` (I can't easily check at the moment as I'm not on a Linux Workstation).
If that's the case, this LGTM and you can submit without another round trip. Thanks for your fix. At some point we should really take a step back and rewrite the disassembler.


Repository:
  rL LLVM

https://reviews.llvm.org/D32466





More information about the llvm-commits mailing list