[PATCH] D32352: Go to eleven

[Zvi Rackover via Phabricator via llvm-commits]

zvi added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:30948
+
+  auto combineMulShlAddOrSub = [&] (int Mult, int Shift, bool isAdd) {
+    Result = DAG.getNode(X86ISD::MUL_IMM, DL, VT, N->getOperand(0),
----------------
Might be just a nitpick of mine (in which case this is merely a suggestion):
1. Consider changing these helpers to return a SDValue object instead of mutating a variable from out of their scope
2. Consider changing the 'switch' below with return's instead of break's (except for the default case, if it is still needed).


https://reviews.llvm.org/D32352