[PATCH] D32466: [llvm-objdump] Don't attempt to print lines beyond the end of file

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: test/tools/llvm-objdump/X86/Inputs/debug-info-fileinfo.S:1-15
+// clang -g debug-info-fileinfo.S -o debug-info-fileinfo.exe -nostdlib
+
+
+.text
+
+.global _start; .type _start, STT_FUNC; _start:
+    ret
----------------
Instead of having a separate file you can put this as a comment of `test/tools/llvm-objdump/X86/debug-info-fileinfo.test`, no?


================
Comment at: test/tools/llvm-objdump/X86/debug-info-fileinfo.test:1
+// RUN: llvm-objdump -S %p/Inputs/debug-info-fileinfo.exe.elf-x86_64 | FileCheck %s
+
----------------
Nit: the permissions for the file are 0755, `0644` should be fine.


================
Comment at: test/tools/llvm-objdump/X86/debug-info-fileinfo.test:3
+
+// CHECK: Disassembly of section .text:
----------------
You can probably dump a little more.


Repository:
  rL LLVM

https://reviews.llvm.org/D32466