[PATCH] D32472: [InstCombine] Remove redundant code from SimplifyUsingDistributiveLaws

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

LGTM. I was just stepping through a few examples that went down this path, and I couldn't see how these cases could trigger either.

One comment about the naming: I'm not sure if anyone else sees it this way, but when I read "simplifyXXX", I assume that we're not creating new instructions. But that's clearly not true for this function, so maybe it's better to rename it "foldUsingDistributiveLaws" or "combineUsingDistributiveLaws"?


https://reviews.llvm.org/D32472