[PATCH] D32117: Update TableGen LangIntro.rst

[Alex Bradbury via Phabricator via llvm-commits]

asb added a reviewer: asb.
asb added a comment.

Hi, thanks for the patch. My feedback is:

1. Limitations of literal formats shouldn't be discussed when introducing the types.
2. Perhaps outside the scope of this patch, but it does seem a little odd that a simple string literal can be assigned to either a string or code variable, but code fragment literals can't be assigned to strings variables (at least on the couple of months old build on LLVM I have on this machine). The existing description that a code fragment is "just a multiline string literal" seems incorrect due to this.



================
Comment at: docs/TableGen/LangIntro.rst:58
 ``string``
-    The 'string' type represents an ordered sequence of characters of arbitrary
-    length.
+    The 'string' type represents an ordered sequence of characters in single line.
+
----------------
It's correct that string literals can't span multiple lines, but I think this really belongs in the discussion later in the document about TableGen values and expressions which documents literal formats.


https://reviews.llvm.org/D32117