[PATCH] D32450: [libunwind] Add 64-bit SPARC support

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd requested changes to this revision.
compnerd added inline comments.
This revision now requires changes to proceed.


================
Comment at: libunwind/src/DwarfInstructions.hpp:89
+    return addressSpace.getP(
+	cfa + (pint_t)savedReg.value) ^ registers.getWCookie();
+
----------------
Please prefer `static_cast` rather than the C-style cast as this is C++ code.


================
Comment at: libunwind/src/DwarfParser.hpp:659
+      _LIBUNWIND_TRACE_DWARF("DW_CGA_GNU_window_save\n");
       break;
     case DW_CFA_GNU_args_size:
----------------
Is the `DW_CFA_GNU_window_save` operand limited to SPARC?  I think that we should handle this generically, not specific to SPARC.  We can add a special case for SPARC if the generic way to handle windows registers doesn't work.


https://reviews.llvm.org/D32450