[PATCH] D32440: [scudo] Move thread local variables into their own files

Aleksey Shlyapnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 14:04:45 PDT 2017


alekseyshl added inline comments.


================
Comment at: lib/scudo/scudo_allocator.h:108
+typedef CombinedAllocator<PrimaryAllocator, AllocatorCache, SecondaryAllocator>
+  ScudoBackendAllocator;
+
----------------
Two more spaces indent.


================
Comment at: lib/scudo/scudo_tls_linux.cpp:30
+static thread_local bool ThreadInited = false;
+static thread_local bool ThreadTornDown = false;
+static thread_local ScudoThreadContext ThreadLocalContext;
----------------
Why those are two separate flags (some combinations are invalid) and not an enum State field in the ThreadLocalContext?


https://reviews.llvm.org/D32440





More information about the llvm-commits mailing list