[PATCH] D32262: [Bitcode] Refactor attribute group writing to avoid getSlotAttributes

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 13:15:02 PDT 2017

Previous message: [PATCH] D32262: [Bitcode] Refactor attribute group writing to avoid getSlotAttributes
Next message: [PATCH] D32262: [Bitcode] Refactor attribute group writing to avoid getSlotAttributes
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

I don't see anything wrong with this, but I don't have 100% confidence. I'll trust your judgement since you probably have more of attributes paged into your head at this point.


https://reviews.llvm.org/D32262

Previous message: [PATCH] D32262: [Bitcode] Refactor attribute group writing to avoid getSlotAttributes
Next message: [PATCH] D32262: [Bitcode] Refactor attribute group writing to avoid getSlotAttributes
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list