[PATCH] D32354: [ELF] - Set DF_STATIC_TLS flag for i386 target.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:207
 
+  if (Target->isTlsInitialExecRel(Type) || Target->isTlsLocalExecRel(Type))
+    Target->StaticTlsModel = true;
----------------
I don't want to bury this code deep inside the relocation processing like this. Can you create a different for loop that visits each input section's Relocations vector elements to see if there's a TLS relocation?


================
Comment at: ELF/Relocations.cpp:208
+  if (Target->isTlsInitialExecRel(Type) || Target->isTlsLocalExecRel(Type))
+    Target->StaticTlsModel = true;
+
----------------
No other members of Target is writable, so you want to treat a Target as an immutable object.


https://reviews.llvm.org/D32354