[PATCH] D32289: [ELF] - Linkerscript: support combination of linkerscript and --compress-debug-sections.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: test/ELF/linkerscript/compress-debug-sections.s:6
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t2.o
+# RUN: echo "SECTIONS { .debug_str 0 : { *(.debug_str) } }" > %t.script
+# RUN: ld.lld %t1.o %t2.o %t.script -o %t --compress-debug-sections=zlib
----------------
What is the point of such linker script? I wonder why do you want to control the layout of .debug_str section.


================
Comment at: test/ELF/linkerscript/compress-debug-sections.s:18-20
+  .asciz "AAAAAAAAAAAAAAAAAAAAAAAAAAA"
+.Linfo_string1:
+  .asciz "BBBBBBBBBBBBBBBBBBBBBBBBBBB"
----------------
nit: Can you reduce number of repetitions of A, B, C and D? Just a few characters should suffice.


https://reviews.llvm.org/D32289