[PATCH] D30107: Make DynamicLibrary::getPermanentLibrary have a defined ordering.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 10:47:03 PDT 2017


vsk added a comment.

In https://reviews.llvm.org/D30107#735022, @marsupial wrote:

> Ming seems to have EnumProcessModules which will also work on Win32, so only use EnumProcessModulesEx on Win64 (where EnumProcessModules will fail!).
>
> Could someone who uses ming32 test if this is working?


You may be able to reach someone more effectively by pinging a mingw32 bot owner.

> If no one steps up, what is the etiquette for using the bots to test?

It's OK to try fixing bots 'speculatively' for a short period of time. However it's best to avoid leaving CI in a bad state for an extended period of time. If there's no immediate fix in sight, I always revert (see llvm/utils/git-svn/git-svnrevert).


https://reviews.llvm.org/D30107





More information about the llvm-commits mailing list