[PATCH] D32417: [APInt] Simplify the zext and sext methods

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D32417#735496, @craig.topper wrote:

> What is the project prefered way of writing memcpy/memset/memmove? A quick grep shows that they are far more often used without std::


I don't think the project has a prefered way. I see both plain "memcpy", "std::memcpy" and "::memcpy".

I like the "std::" variant and think it's the most correct one, but I also don't think this matters much.

lgtm



================
Comment at: lib/Support/APInt.cpp:955
+  Result.pVal[getNumWords() - 1] = SignExtend64(Result.pVal[getNumWords() - 1],
+                                      ((BitWidth-1) % APINT_BITS_PER_WORD) + 1);
 
----------------
nit: spaces around `-`


https://reviews.llvm.org/D32417