[PATCH] D32344: InstCombine/AMDGPU: Fix constant folding of llvm.amdgcn.{icmp, fcmp}

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:3435-3437
+        if (CCmp->isNullValue())
+          return replaceInstUsesWith(
+              *II, ConstantExpr::getSExt(CCmp, II->getType()));
----------------
Multiline, so braces


================
Comment at: test/Transforms/InstCombine/amdgcn-intrinsics.ll:1538
   ret i64 %result
 }
----------------
arsenm wrote:
> Check that attributes 4 contains convergent?
This is really missing nounwind?


https://reviews.llvm.org/D32344