[PATCH] D32056: AMDGPU: Move trap lowering to DAG

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: docs/AMDGPUUsage.rst:86
    llvm.trap       s_endpgm      Causes wavefront to be terminated.
-   llvm.debugtrap  s_nop         No operation. Compiler warning generated that
-                                 there is no trap handler installed.
+   llvm.debugtrapnone Nothing. Compiler warning generated that there is no trap handler installed.
    =============== ============= ===============================================
----------------
formatting.


================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:2404
+                                     Op.getDebugLoc(),
+                                     DS_Warning);
+    LLVMContext &Ctx = MF.getFunction()->getContext();
----------------
t-tye wrote:
> arsenm wrote:
> > kzhuravl wrote:
> > > Can we make it an error?
> > We decided this should be a warning before, this isn't changing that
> If there is no trap handler (namely it is not amdhsa) then the code generated is simply ignoring the llvm.debugtrap. So in this case is it better to give a warning or an error? If the llvm.debugtrap was present for a reason then ignoring it without giving an error may not be very helpful.
was the question answered?


https://reviews.llvm.org/D32056