[PATCH] D30086: Add generic IR vector reductions

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked 3 inline comments as done.
aemerson added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUtils.cpp:1191
+
+Value *llvm::createTargetReduction(IRBuilder<> &Builder,
+                                   const TargetTransformInfo *TTI,
----------------
delena wrote:
> You implemented 2 functions with the same name. It's not clear what the difference between them. Please add some comments before each of them.
I've added some comments to the API in the header, but I'll flesh those out more and add some short ones here too.


Repository:
  rL LLVM

https://reviews.llvm.org/D30086