[PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

Nitesh Jain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 24 03:47:13 PDT 2017


nitesh.jain added a comment.

In https://reviews.llvm.org/D32125#734500, @emaste wrote:

> In https://reviews.llvm.org/D32125#728166, @krytarowski wrote:
>
> > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.
> >
> > It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved.
>
>
> I'd say it's better to put a comment in the source where it's set.


Added comment in the source.


https://reviews.llvm.org/D32125





More information about the llvm-commits mailing list