[PATCH] D32409: [PM/LoopUnswitch] Introduce a new, simpler loop unswitch pass.

Sun Apr 23 15:50:53 PDT 2017

chandlerc created this revision.
Herald added subscribers: mgorny, mcrosier, mehdi_amini.

Currently, this pass only focuses on *trivial* loop unswitching. At that
reduced problem it remains dramatically better than the current loop
unswitch is.

- Old pass is worse than cubic complexity. New pass is (I think) linear.
- New pass is much simpler in its design by focusing on full unswitching. (See below for details on this).
- New pass doesn't carry state for thresholds between pass iterations.
- New pass doesn't carry state for correctness (both miscompile and infloop) between pass iterations.
- New pass produces substantially better code after unswitching.
- New pass can handle more trivial unswitch cases.
- New pass doesn't recompute the dominator tree for the entire function and instead incrementally updates it.

I've ported all of the trivial unswitching test cases from the old pass
to the new one to make sure that major functionality isn't lost in the
process. For several of the test cases I've worked to improve the
precision and rigor of the CHECKs, but for many I've just updated them
to handle the new IR produced.

My initial motivation was the fact that the old pass carried state in
very unreliable ways between pass iterations, and these mechansims were
incompatible with the new pass manager. However, I discovered many more
improvements to make along the way.

This pass makes two very significant assumptions that enable most of these
improvements:

1. Focus on *full* unswitching -- that is, completely removing whatever control flow construct is being unswitched from the loop. In the case of trivial unswitching, this means removing the trivial (exiting) edge. In non-trivial unswitching, this means removing the branch or switch itself. This is in opposition to *partial* unswitching where some part of the unswitched control flow remains in the loop. Partial unswitching only really applies to switches and to folded branches. These are very similar to full unrolling and partial unrolling. The full form is an effective canonicalization, the partial form needs a complex cost model, cannot be iterated, isn't canonicalizing, and should be a separate pass that runs very late (much like unrolling).

2. Leverage LLVM's Loop machinery to the fullest. The original unswitch dates from a time when a great deal of LLVM's loop infrastructure was missing, ineffective, and/or unreliable. As a consequence, a lot of complexity was added which we no longer need.

With these two overarching principles, I think we can build a fast and
effective unswitcher that fits in well in the new PM and in the
canonicalization pipeline. Some of the remaining functionality around
partial unswitching may not be relevant today (not many test cases or
benchmarks I can find) but if they are I'd like to add support for them
as a separate layer that runs very late in the pipeline.

Purely to make reviewing and introducing this code more manageable, I've
split this into first a trivial-unswitch-only pass and in the next patch
I'll add support for full non-trivial unswitching against a *fixed*
threshold, exactly like full unrolling. I even plan to re-use the
unrolling thresholds, as these are incredibly similar cost tradeoffs:
we're cloning a loop body in order to end up with simplified control
flow. We should only do that when the total growth is reasonably small.

One of the biggest changes with this pass compared to the previous one
is that previously, each individual trivial exiting edge from a switch
was unswitched separately as a branch. Now, we unswitch the entire
switch at once, with cases going to the various destinations. This lets
us unswitch multiple exiting edges in a single operation and also avoids
numerous extremely bad behaviors, where we would introduce 1000s of
branches to test for thousands of possible values, all of which would
take the exact same exit path bypassing the loop. Now we will use
a switch with 1000s of cases that can be efficiently lowered into
a jumptable. This avoids relying on somehow forming a switch out of the
branches or getting horrible code if that fails for any reason.

Another significant change is that this pass actively updates the CFG
based on unswitching. For trivial unswitching, this is actually very
easy because of the definition of loop simplified form. Doing this makes
the code coming out of loop unswitch dramatically more friendly. We
still should run loop-simplifycfg (at the least) after this to clean up,
but it will have to do a lot less work.

Finally, this pass makes much fewer attempts to simplify instructions
based on the unswitch. Something like loop-instsimplify, instcombine, or
GVN can be used to do increasingly powerful simplifications based on the
now dominating predicate. The old simplifications are things that
something like loop-instsimplify should get today or a very, very basic
loop-instcombine could get. Keeping that logic separate is a big
simplifying technique.

Most of the code in this pass that isn't in the old one has to do with
achieving specific goals:

- Updating teh dominator tree as we go
- Unswitching all cases in a switch in a single step.

I think it is still shorter than just the trivial unswitching code in the old
pass despite having this functionality.

https://reviews.llvm.org/D32409

Files:
  include/llvm/InitializePasses.h
  include/llvm/Transforms/Scalar/SimpleLoopUnswitch.h
  lib/Passes/PassBuilder.cpp
  lib/Passes/PassRegistry.def
  lib/Transforms/IPO/PassManagerBuilder.cpp
  lib/Transforms/Scalar/CMakeLists.txt
  lib/Transforms/Scalar/Scalar.cpp
  lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
  test/Transforms/SimpleLoopUnswitch/2006-06-13-SingleEntryPHI.ll
  test/Transforms/SimpleLoopUnswitch/2006-06-27-DeadSwitchCase.ll
  test/Transforms/SimpleLoopUnswitch/2007-05-09-Unreachable.ll
  test/Transforms/SimpleLoopUnswitch/2007-05-09-tl.ll
  test/Transforms/SimpleLoopUnswitch/2007-07-12-ExitDomInfo.ll
  test/Transforms/SimpleLoopUnswitch/2007-07-13-DomInfo.ll
  test/Transforms/SimpleLoopUnswitch/2007-07-18-DomInfo.ll
  test/Transforms/SimpleLoopUnswitch/2007-08-01-Dom.ll
  test/Transforms/SimpleLoopUnswitch/2007-08-01-LCSSA.ll
  test/Transforms/SimpleLoopUnswitch/2007-10-04-DomFrontier.ll
  test/Transforms/SimpleLoopUnswitch/2008-06-02-DomInfo.ll
  test/Transforms/SimpleLoopUnswitch/2008-06-17-DomFrontier.ll
  test/Transforms/SimpleLoopUnswitch/2010-11-18-LCSSA.ll
  test/Transforms/SimpleLoopUnswitch/2011-06-02-CritSwitch.ll
  test/Transforms/SimpleLoopUnswitch/2011-09-26-EHCrash.ll
  test/Transforms/SimpleLoopUnswitch/2012-04-02-IndirectBr.ll
  test/Transforms/SimpleLoopUnswitch/2012-04-30-LoopUnswitch-LPad-Crash.ll
  test/Transforms/SimpleLoopUnswitch/2012-05-20-Phi.ll
  test/Transforms/SimpleLoopUnswitch/2015-09-18-Addrspace.ll
  test/Transforms/SimpleLoopUnswitch/LIV-loop-condtion.ll
  test/Transforms/SimpleLoopUnswitch/basictest.ll
  test/Transforms/SimpleLoopUnswitch/cleanuppad.ll
  test/Transforms/SimpleLoopUnswitch/copy-metadata.ll
  test/Transforms/SimpleLoopUnswitch/crash.ll
  test/Transforms/SimpleLoopUnswitch/exponential-behavior.ll
  test/Transforms/SimpleLoopUnswitch/infinite-loop.ll
  test/Transforms/SimpleLoopUnswitch/msan.ll
  test/Transforms/SimpleLoopUnswitch/preserve-analyses.ll
  test/Transforms/SimpleLoopUnswitch/trivial-unswitch.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32409.96331.patch
Type: text/x-patch
Size: 98898 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170423/5c65aea5/attachment.bin>