[PATCH] D32039: PR31357 fix

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 23 05:40:10 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:3895
 
-  unsigned Num;
+  unsigned mask;
   switch (N1C->getZExtValue()) {
----------------
Style guide says variables should be Capitalized. It might be clearer to call it MaskByteOffset or similar. If possible this should be done as a separate NFC commit.


https://reviews.llvm.org/D32039





More information about the llvm-commits mailing list