[PATCH] D32162: Inline asm 0bH conflict
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Apr 23 05:32:03 PDT 2017
RKSimon added inline comments.
================
Comment at: lib/MC/MCParser/AsmParser.cpp:740
AsmCond StartingCondState = TheCondState;
+ SmallVector<AsmRewrite, 4> AsmStrRewrites;
----------------
avt77 wrote:
> RKSimon wrote:
> > avt77 wrote:
> > > craig.topper wrote:
> > > > What is this change for?
> > > It's used below in "parseStatement". Without it"parseStatement" crashes.
> > Should we even allow a ParseStatementInfo default constructor in that case?
> From my point of view we should not.
OK - please can you remove the default constructor as part of this patch.
https://reviews.llvm.org/D32162
More information about the llvm-commits
mailing list