[PATCH] D32120: Don't test setting sticky bits on files for (Free|Open)BSD

[Ed Maste via Phabricator via llvm-commits]

emaste added a comment.

In https://reviews.llvm.org/D32120#734603, @krytarowski wrote:

> I don't agree. It would mean that it's supposed to work on BSD4.4 and derivate systems like BSD/OS.


I think it would be useful to have a #define for modern BSDs though, as presumably DragonFly, bitrig, EdgeBSD etc. will need it set as well (although some/all may still include the #define inherited from their parent).



================
Comment at: unittests/Support/Path.cpp:1518
 
+  // FreeBSD, NetBSD and OpenBSD require root to set the sticky bit on files.
+#if !defined(__FreeBSD__) && !defined(__NetBSD__) && !defined(__OpenBSD__)
----------------
Maybe just "Modern BSDs require..." so that the comment doesn't repeat the test and need to be updated if/when another one is added?


https://reviews.llvm.org/D32120