[PATCH] D32388: InstructionSimplify: One getShuffleMask() replacing multiple getMaskValue(). NFC.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 22 05:07:01 PDT 2017


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM with one minor



================
Comment at: lib/Analysis/InstructionSimplify.cpp:4155
+  SmallVector<int, 32> Indices;
+  ShuffleVectorInst::getShuffleMask(Mask, Indices);
+
----------------
Might be overkill but maybe add assert for MaskNumElts == Indices.size() ?


Repository:
  rL LLVM

https://reviews.llvm.org/D32388





More information about the llvm-commits mailing list