[PATCH] D31630: [tsan] Detect races on modifying accesses in Swift code

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added a comment.

In https://reviews.llvm.org/D31630#730957, @dvyukov wrote:

> In https://reviews.llvm.org/D31630#721583, @dvyukov wrote:
>
> > Hi Kuba,
> >
> > I've seen a bunch of changes from you and they all are marked in my inbox. The past 1.5 weeks I was travelling and next week I am OOO so won't be able to review them. Just wanted to let you know.
>
>
> I am back. Slowly working on backlog.


I now think that I replied to all pending reviews. If there is anything left, please ping them.



================
Comment at: lib/tsan/rtl/tsan_report.cc:215
     } else {
       Printf("  Location is %s object of size %zu at %p allocated by %s:\n",
              object_type, loc->heap_chunk_size, loc->heap_chunk_start,
----------------
It's better to drop "object" here to make it more general. A user can always add "object" to tag name if necessary.


================
Comment at: lib/tsan/rtl/tsan_suppressions.cc:79
     return kSuppressionRace;
+  else if (typ == ReportTypeSwiftAccessRace)
+    return kSuppressionRace;
----------------
It seems to me that we now won't see ReportTypeExternalRace/ReportTypeSwiftAccessRace here.


https://reviews.llvm.org/D31630