[PATCH] D31689: [tsan] Summary should point to "responsible caller" for external races

[Dmitry Vyukov via Phabricator via llvm-commits]

dvyukov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_report.cc:384
+    if (SymbolizedStack *frame = SkipTsanInternalFrames(stack->frames)) {
+      if (rep->typ == ReportTypeExternalRace) {
+        // For external races, the responsible frame is 2nd from the top
----------------
This conflicts with D31630.
rep->typ == ReportTypeExternalRace can be, but this stack may not be an external access.
Let's first land D31630 and then get back to this.


Repository:
  rL LLVM

https://reviews.llvm.org/D31689