[PATCH] D31628: Add Explanation of Mips Backend Relocation Principles

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. Two tiny nits inlined.

Thanks for doing the documentation.
Simon



================
Comment at: lib/Target/Mips/Relocation.txt:52
+Here the instantiation of MipsHiLoRelocs in MipsInstrInfo.td is used
+by MIPS32 to compute addresses for the static relocation model.
+
----------------
by -> for.


================
Comment at: lib/Target/Mips/Relocation.txt:70
+
+The instantiation in Mips64InstrInfo.td is used by MIPS64 in ILP32
+mode, as guarded by the predicate "SYM_32" and also for a submode of
----------------
by -> for.


================
Comment at: lib/Target/Mips/Relocation.txt:123
+defines two names "LUi" and "LUi64" with two different register
+classes, but with the same encoding---"LUI_FM". These load a 16-bit
+immediate into bits 31-16 and clear the lower 15 bits. On MIPS64, the
----------------
"These" -> "These instructions"


https://reviews.llvm.org/D31628