[PATCH] D31604: [DebugInfo][X86] Improve X86 Optimize LEAs handling of debug values.

[Andrew Ng via Phabricator via llvm-commits]

andrewng added inline comments.


================
Comment at: lib/Target/X86/X86OptimizeLEAs.cpp:550
+  int64_t Offset = (IsIndirect ? MI.getOperand(1).getImm() : 0) + AddrDispShift;
+  if (!IsIndirect && (Offset != 0)) {
+    // If required create new DIExpression with DW_OP_stack_value prepended to
----------------
aprantl wrote:
> Is AddrDispShift always > 0?
I believe that AddrDispShift can be either positive or negative. I assume that it won't be zero as that would imply there were two "identical" LEAs.


https://reviews.llvm.org/D31604