[llvm] r300959 - Rename FastString flag.
Clement Courbet via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 21 02:20:50 PDT 2017
Author: courbet
Date: Fri Apr 21 04:20:50 2017
New Revision: 300959
URL: http://llvm.org/viewvc/llvm-project?rev=300959&view=rev
Log:
Rename FastString flag.
Modified:
llvm/trunk/lib/Target/X86/X86.td
llvm/trunk/lib/Target/X86/X86InstrInfo.td
llvm/trunk/lib/Target/X86/X86SelectionDAGInfo.cpp
llvm/trunk/lib/Target/X86/X86Subtarget.cpp
llvm/trunk/lib/Target/X86/X86Subtarget.h
llvm/trunk/test/CodeGen/X86/memcpy-struct-by-value.ll
Modified: llvm/trunk/lib/Target/X86/X86.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86.td?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86.td (original)
+++ llvm/trunk/lib/Target/X86/X86.td Fri Apr 21 04:20:50 2017
@@ -273,11 +273,14 @@ def FeatureFastSHLDRotate
"fast-shld-rotate", "HasFastSHLDRotate", "true",
"SHLD can be used as a faster rotate">;
-// String operations (e.g. REP MOVS) are fast. See "REP String Enhancement" in
-// the Intel Software Development Manual.
-def FeatureFastString
+// Ivy Bridge and newer processors have enhanced REP MOVSB and STOSB (aka
+// "string operations"). See "REP String Enhancement" in the Intel Software
+// Development Manual. This feature essentially meanis that REP MOVSB will copy
+// using the largest available size instead of copying bytes one by one, making
+// it at least as fast as REPMOVS{W,D,Q}.
+def FeatureERMSB
: SubtargetFeature<
- "fast-string", "HasFastString", "true",
+ "ermsb", "HasERMSB", "true",
"REP MOVS/STOS are fast">;
//===----------------------------------------------------------------------===//
@@ -505,7 +508,7 @@ def HSWFeatures : ProcessorFeatures<IVBF
FeatureAVX2,
FeatureBMI,
FeatureBMI2,
- FeatureFastString,
+ FeatureERMSB,
FeatureFMA,
FeatureLZCNT,
FeatureMOVBE,
Modified: llvm/trunk/lib/Target/X86/X86InstrInfo.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.td?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrInfo.td (original)
+++ llvm/trunk/lib/Target/X86/X86InstrInfo.td Fri Apr 21 04:20:50 2017
@@ -897,7 +897,7 @@ def NotSlowIncDec : Predicate<"!Subtarge
def HasFastMem32 : Predicate<"!Subtarget->isUnalignedMem32Slow()">;
def HasFastLZCNT : Predicate<"Subtarget->hasFastLZCNT()">;
def HasFastSHLDRotate : Predicate<"Subtarget->hasFastSHLDRotate()">;
-def HasFastString : Predicate<"Subtarget->hasFastString()">;
+def HasERMSB : Predicate<"Subtarget->hasERMSB()">;
def HasMFence : Predicate<"Subtarget->hasMFence()">;
//===----------------------------------------------------------------------===//
Modified: llvm/trunk/lib/Target/X86/X86SelectionDAGInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86SelectionDAGInfo.cpp?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86SelectionDAGInfo.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86SelectionDAGInfo.cpp Fri Apr 21 04:20:50 2017
@@ -215,8 +215,8 @@ SDValue X86SelectionDAGInfo::EmitTargetC
return SDValue();
MVT AVT;
- if (Subtarget.hasFastString())
- // If the target has fast strings, then it's at least as fast to use
+ if (Subtarget.hasERMSB())
+ // If the target has enhanced REPMOVSB, then it's at least as fast to use
// REP MOVSB instead of REP MOVS{W,D,Q}, and it avoids having to handle
// BytesLeft.
AVT = MVT::i8;
Modified: llvm/trunk/lib/Target/X86/X86Subtarget.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.cpp Fri Apr 21 04:20:50 2017
@@ -303,7 +303,7 @@ void X86Subtarget::initializeEnvironment
HasFastVectorFSQRT = false;
HasFastLZCNT = false;
HasFastSHLDRotate = false;
- HasFastString = false;
+ HasERMSB = false;
HasSlowDivide32 = false;
HasSlowDivide64 = false;
PadShortFunctions = false;
Modified: llvm/trunk/lib/Target/X86/X86Subtarget.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.h?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86Subtarget.h (original)
+++ llvm/trunk/lib/Target/X86/X86Subtarget.h Fri Apr 21 04:20:50 2017
@@ -232,8 +232,8 @@ protected:
/// True if SHLD based rotate is fast.
bool HasFastSHLDRotate;
- /// True if the processor has fast REP MOVS.
- bool HasFastString;
+ /// True if the processor has enhanced REP MOVSB/STOSB.
+ bool HasERMSB;
/// True if the short functions should be padded to prevent
/// a stall when returning too early.
@@ -475,7 +475,7 @@ public:
bool hasFastVectorFSQRT() const { return HasFastVectorFSQRT; }
bool hasFastLZCNT() const { return HasFastLZCNT; }
bool hasFastSHLDRotate() const { return HasFastSHLDRotate; }
- bool hasFastString() const { return HasFastString; }
+ bool hasERMSB() const { return HasERMSB; }
bool hasSlowDivide32() const { return HasSlowDivide32; }
bool hasSlowDivide64() const { return HasSlowDivide64; }
bool padShortFunctions() const { return PadShortFunctions; }
Modified: llvm/trunk/test/CodeGen/X86/memcpy-struct-by-value.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/memcpy-struct-by-value.ll?rev=300959&r1=300958&r2=300959&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/memcpy-struct-by-value.ll (original)
+++ llvm/trunk/test/CodeGen/X86/memcpy-struct-by-value.ll Fri Apr 21 04:20:50 2017
@@ -1,5 +1,5 @@
-; RUN: llc -mtriple=x86_64-linux-gnu -mattr=-fast-string < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=NOFAST
-; RUN: llc -mtriple=x86_64-linux-gnu -mattr=+fast-string < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=FAST
+; RUN: llc -mtriple=x86_64-linux-gnu -mattr=-ermsb < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=NOFAST
+; RUN: llc -mtriple=x86_64-linux-gnu -mattr=+ermsb < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=FAST
; RUN: llc -mtriple=x86_64-linux-gnu -mcpu=haswell < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=HASWELL
; RUN: llc -mtriple=x86_64-linux-gnu -mcpu=generic < %s -o - | FileCheck %s --check-prefix=ALL --check-prefix=GENERIC
More information about the llvm-commits
mailing list