[PATCH] D32186: CodeGen: Add a hook for getFenceOperandTy

Konstantin Zhuravlyov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 22:32:53 PDT 2017


kzhuravl added inline comments.


================
Comment at: include/llvm/Target/TargetLowering.h:242
+    return getPointerTy(DL);
+  }
   /// EVT is not used in-tree, but is used by out-of-tree target.
----------------
new line.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:97
 //===----------------------------------------------------------------------===//
+def ATOMIC_FENCE : InstSI<
+  (outs), (ins i32imm:$ordering, i32imm:$scope),
----------------
InstSI -> SPseudoInstSI.


================
Comment at: lib/Target/AMDGPU/SIInstructions.td:102-104
+  let isCodeGenOnly = 1;
+  let isPseudo = 1;
+  let SALU = 1;
----------------
Remove these, as those are inherited from SPseudoInstSI.


https://reviews.llvm.org/D32186





More information about the llvm-commits mailing list