[PATCH] D32317: [coff] for /msvclto, pass archive members with prevailing symbols first
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 18:32:38 PDT 2017
pcc added inline comments.
================
Comment at: COFF/Driver.cpp:529
+ OS << O->MB.getBuffer();
+ EarlyObjects.push_back(S.str());
+ Rsp += quote(S);
----------------
Can't you s/EarlyObjects/Temps/ here and remove the code dealing with EarlyObjects?
================
Comment at: COFF/Driver.cpp:530
+ EarlyObjects.push_back(S.str());
+ Rsp += quote(S);
+ }
----------------
Don't you need to append a newline here?
================
Comment at: test/COFF/msvclto-order.ll:12
+; CHECK-NOT: .lib{{$}}
+; CHECK: lld-msvclto-order-a{{.*}}.obj
+; CHECK: .lib{{$}}
----------------
`CHECK-NOT: lld-msvclto-order-b`?
https://reviews.llvm.org/D32317
More information about the llvm-commits
mailing list