[PATCH] D31837: [cfi] Run tests with and without lld and thinlto.

[Evgeniy Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: test/cfi/cross-dso/lit.local.cfg:12
+if root.use_thinlto:
+  config.unsupported = True
----------------
pcc wrote:
> I thought you mentioned that cross-DSO already works for the most part under ThinLTO. If not, you can revert your change to stats.cpp.
Good catch. That was meant to go in cross-dso/icall/lit.local.cfg.



================
Comment at: test/cfi/lit.cfg:4
 
-config.name = 'cfi'
+config.name = 'cfi' + config.name_suffix
 config.suffixes = ['.c', '.cpp', '.test']
----------------
pcc wrote:
> Why is this change necessary now?
I can do it in a separate change if you want. Now we have a lot more different configs, so this is becoming important.

Failing Tests (20):
    cfi :: cross-dso/icall/dlopen.cpp
    cfi :: cross-dso/icall/dlopen.cpp
    cfi :: cross-dso/icall/dlopen.cpp
    cfi :: cross-dso/icall/dlopen.cpp
    cfi :: cross-dso/icall/icall-from-dso.cpp
    cfi :: cross-dso/icall/icall-from-dso.cpp
    cfi :: cross-dso/icall/icall-from-dso.cpp
    cfi :: cross-dso/icall/icall-from-dso.cpp
    cfi :: cross-dso/icall/icall.cpp
    cfi :: cross-dso/icall/icall.cpp
    cfi :: cross-dso/icall/icall.cpp
    cfi :: cross-dso/icall/icall.cpp
    cfi :: cross-dso/stats.cpp
    cfi :: cross-dso/stats.cpp
    cfi :: cross-dso/stats.cpp
    cfi :: cross-dso/stats.cpp
    cfi :: icall/external-call.c
    cfi :: icall/external-call.c
    cfi :: icall/external-call.c
    cfi :: icall/external-call.c

(^ without the change)


================
Comment at: test/lit.common.cfg:132
 if config.has_lld:
+  config.available_features.add('have-lld')
+
----------------
pcc wrote:
> Are you using this feature name?
Yes! Renamed to "lld-available".


Repository:
  rL LLVM

https://reviews.llvm.org/D31837