[PATCH] D32315: Introduce a new DWARFContext::getInliningInfoForAddress API to expose pointers to strings stored in DWARF file.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFContext.h:208
+      std::function<void(const char *, const char *, const char *, const char *,
+                         uint32_t, uint32_t, uint32_t, uint32_t)>
+          Inserter);
----------------
I'm not a fan of this type. Seems awfully easy to confuse the arguments. Since this function is only used in one place, do we even have to generalize it with std::function argument?


https://reviews.llvm.org/D32315