[PATCH] D31837: [cfi] Run tests with and without lld and thinlto.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 15:24:31 PDT 2017


pcc added inline comments.


================
Comment at: test/cfi/cross-dso/lit.local.cfg:12
+if root.use_thinlto:
+  config.unsupported = True
----------------
I thought you mentioned that cross-DSO already works for the most part under ThinLTO. If not, you can revert your change to stats.cpp.


================
Comment at: test/cfi/lit.cfg:4
 
-config.name = 'cfi'
+config.name = 'cfi' + config.name_suffix
 config.suffixes = ['.c', '.cpp', '.test']
----------------
Why is this change necessary now?


================
Comment at: test/lit.common.cfg:132
 if config.has_lld:
+  config.available_features.add('have-lld')
+
----------------
Are you using this feature name?


Repository:
  rL LLVM

https://reviews.llvm.org/D31837





More information about the llvm-commits mailing list