[PATCH] D32308: Use BasicBlock Util SplitBlock interface to update DT
Wei Mi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 20 14:06:09 PDT 2017
wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:221
// incoming values from inside of the region.
- BasicBlock::iterator AfterPHIs = Header->getFirstNonPHI()->getIterator();
- BasicBlock *NewBB = Header->splitBasicBlock(AfterPHIs,
- Header->getName()+".ce");
+ BasicBlock::iterator AfterPHIs;
+
----------------
nit: AfterPHIs can be moved closer to its use.
https://reviews.llvm.org/D32308
More information about the llvm-commits
mailing list