[PATCH] D31924: SROA: Allow eliminating addrspacecasted allocas

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 13:18:56 PDT 2017


arsenm added inline comments.


================
Comment at: docs/LangRef.rst:8460
+same memory location. The pointer conversion cannot be an arbitrarily
+complex value modification. For a defined result, the inverse cast to
+the original address space should yield the original pointer value.
----------------
efriedma wrote:
> "The pointer conversion cannot be an arbitrarily complex value modification." is a bit vague... it'd be better if we could specifically say what transforms are allowed.
Would just dropping that sentence work? The intent is more clear in the second sentence where it needs to be reversible


https://reviews.llvm.org/D31924





More information about the llvm-commits mailing list