[PATCH] D31750: [globalisel] Enable tracing the legalizer with --debug-only=legalize-mir

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 13:11:45 PDT 2017


aditya_nandakumar added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/Legalizer.cpp:204
+          DEBUG(dbgs() << ".. .. Emitted " << NumNewInsns << " insns\n");
+          for (SmallVector<MachineInstr *, 4>::iterator
+                   I = WorkList.end() - NumNewInsns,
----------------
dsanders wrote:
> kristof.beyls wrote:
> > Minor nitpick: maybe use auto& here to make the code slightly more readable?
> > Otherwise, LGTM.
> Thanks.
Quick question here - is it possible that one of the instructions could have been erased as it went through legalization (and we're trying to print it)?


https://reviews.llvm.org/D31750





More information about the llvm-commits mailing list