[PATCH] D32275: [globalisel][tablegen] Add several GINodeEquiv's for operators that do not require additional support.

Ahmed Bougacha via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 12:01:19 PDT 2017


ab added a comment.

In https://reviews.llvm.org/D32275#732465, @dsanders wrote:

> In https://reviews.llvm.org/D32275#732358, @ab wrote:
>
> > and also have a test that fails when we add more (maybe something trivial like the number of emitted patterns?)
>
>
> I'm not sure I understand this bit. Is the intent to prompt us to look at the new rules?


Yeah, otherwise I'm guessing the generated tests stop covering everything as soon as something else is added, unless we automate it somehow.  (so the main actionable thing would really be "generate tests for the new stuff")


https://reviews.llvm.org/D32275





More information about the llvm-commits mailing list