[PATCH] D32305: [CodeExtractor] Remove a bunch of unneeded constructors

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 12:00:40 PDT 2017


davide added a comment.

In https://reviews.llvm.org/D32305#732439, @davidxl wrote:

> lgtm.
>
> by the way,  what is your PM setup for partial inlining?


Unfortunately, once I start playing with it, I hit this crash and I started debugging, so I didn't had yet time to put at different places in the pipeline.
You have already tried some configurations? Aside, I noticed partial inlining isn't using BB frequency informations (which I found odd, but probably  it's because nobody cared).
I imagine at least a simple heuristic where you split functions comparing as GCC does, IIRC (or at least, used to do at some point).
There was some initial work on this, but, alas, it's unfinished https://reviews.llvm.org/D22744


Repository:
  rL LLVM

https://reviews.llvm.org/D32305





More information about the llvm-commits mailing list