[llvm] r300807 - Do not run frame verification if target does not use frame instructions

Serge Pavlov via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 09:59:03 PDT 2017


This change is in the code that is not called normally, in contrast to
PEI::calculateCallFrameInfo, so there is no target for which it could fix a
bug. On the other hand there are stackless architectures supported in llvm
that could be affected.

If this is not sufficient for justification, I will revert this change, as
I don't know particular problem.
Sorry for troubles.

Thanks,
--Serge

2017-04-20 21:19 GMT+07:00 Davide Italiano <davide at freebsd.org>:

> On Wed, Apr 19, 2017 at 10:35 PM, Serge Pavlov <sepavloff at gmail.com>
> wrote:
> > These lines were copied from PEI::calculateCallFrameInfo. To test them we
> > need a target that do not use frame instructions, it could be a stackless
> > architecture. I cannot find such in intree targets.
> > Anyway the change is obvious and useful for some targets.
> >
>
> I can see this patch committed if somebody is actually leveraging it
> (even out-of-tree). Do you have such an example?
> Otherwise, it's pretty much code thrown in the tree (which is not ideal).
>
> --
> Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170420/6c1af831/attachment.html>


More information about the llvm-commits mailing list