[PATCH] D32244: [BitVector] Add << and >> operators

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 09:37:22 PDT 2017


hans added inline comments.


================
Comment at: llvm/trunk/include/llvm/ADT/BitVector.h:478
+    // shifting this word to make room for the new bits.  This has to be done
+    // for every word in the array.
+
----------------
This sounds like exactly what APInt:tcShiftRight does. Would it be possible to reuse that code?

In general, it seems like a lot of what BitVector does is also implemented in APInt. Craig, what do you think?


Repository:
  rL LLVM

https://reviews.llvm.org/D32244





More information about the llvm-commits mailing list