[PATCH] D32242: [scudo] Minor changes and refactoring

Dmitry Vyukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 06:16:55 PDT 2017


dvyukov accepted this revision.
dvyukov added a comment.
This revision is now accepted and ready to land.

LGTM with a nit



================
Comment at: lib/scudo/scudo_allocator.cpp:363
         static_cast<uptr>(Options.ThreadLocalQuarantineSizeKb) << 10);
+    FallbackMutex.Init();
     BackendAllocator.InitCache(&FallbackAllocatorCache);
----------------
StaticSpinMutex does not need initialization. If anything this can only do harm if the mutex turned out to be locked by somebody else at the moment.
Drop this.


https://reviews.llvm.org/D32242





More information about the llvm-commits mailing list