[PATCH] D31418: [globalisel][tablegen] Import SelectionDAG's rule predicates and support the equivalent in GIRule.

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM with nits.



================
Comment at: lib/Target/AArch64/AArch64InstructionSelector.cpp:80
+  PredicateBitset AvailableFeatures;
+  PredicateBitset getAvailableFeatures() const { return AvailableFeatures; }
+  PredicateBitset
----------------
This getter doesn't seem to be used anymore.


================
Comment at: utils/TableGen/SubtargetFeatureInfo.h:56
 
+  /// Emit the subtarget feature flag definitions.
+  static void emitSubtargetFeatureBitEnumeration(
----------------
I think this function needs a more verbose comment to highlight the differences between it and emitSubtargetFeatureFlagEnumeration.


================
Comment at: utils/TableGen/SubtargetFeatureInfo.h:91
+  /// \param SubtargetFeatures A map of TableGen records to the
+  ///                          SubtargetFeatureInfo equivalent.
+  static void emitComputeAssemblerAvailableFeatures(
----------------
This has the exact same comment as emitComputeAvailableFeatures. I think you should make it more clear why we need two different functions and what each of them does.


https://reviews.llvm.org/D31418