[PATCH] D32282: [ARM] ACLE Chapter 9 support

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Headers/arm_acle.h:327
+/* 9.5.5 Packing and unpacking */
+#if __ARM_FEATURE_SIMD32
+static __inline__ int16x2_t __attribute__((__always_inline__, __nodebug__))
----------------
samparker wrote:
> rengolin wrote:
> > samparker wrote:
> > > rengolin wrote:
> > > > Is `arm_neon.h` guaranteed to have been included by now?
> > > no, but clang does build this macro for suitable targets.
> > right. My worry is that the neon types used below may not be recognised, even if the user doesn't use them.
> > 
> > so:
> > 
> >     #include <arm_acle.h>
> > 
> > can give errors like:
> > 
> >     unknown type int16x2_t
> > 
> > on setups that have NEON, even if not in use by any user code.
> The ACLE states that these types should be typedef'd in arm_acle.h, which I have done just about on line 315. I can't say I know much about NEON, so am I missing something else?
Right, I see. Wouldnt' it be better if the types were defined inside the #if SIMD32?


https://reviews.llvm.org/D32282