[PATCH] D32171: [ELF] - Implemented --defsym option #2

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:884
+// 3) --defsym=name=expression
+// We support first two. Alias implemented very similar to --wrap option,
+// second form simply creates an absolute symbol. We do not support
----------------
ruiu wrote:
> I'd support just 1.
Done.


================
Comment at: ELF/Driver.cpp:887
+// expressions with math for simplicity.
+template <class ELFT> static void handleDefsym(opt::InputArgList &Args) {
+  std::vector<std::pair<StringRef, StringRef>> Ret;
----------------
ruiu wrote:
> Make this a function that returns a vector of pair<StringRef, StringRef> and use alias function in link().
Done.


https://reviews.llvm.org/D32171