[PATCH] D32282: [ARM] ACLE Chapter 9 support

[Renato Golin via Phabricator via llvm-commits]

rengolin added inline comments.


================
Comment at: lib/Headers/arm_acle.h:327
+/* 9.5.5 Packing and unpacking */
+#if __ARM_FEATURE_SIMD32
+static __inline__ int16x2_t __attribute__((__always_inline__, __nodebug__))
----------------
samparker wrote:
> rengolin wrote:
> > Is `arm_neon.h` guaranteed to have been included by now?
> no, but clang does build this macro for suitable targets.
right. My worry is that the neon types used below may not be recognised, even if the user doesn't use them.

so:

    #include <arm_acle.h>

can give errors like:

    unknown type int16x2_t

on setups that have NEON, even if not in use by any user code.


https://reviews.llvm.org/D32282