[PATCH] D32281: [ARM] ACLE Chapter 9 intrinsics

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Hi Sam,

This is a big patch, with lots of smaller changes within. Normally, I'd ask you to split into smaller patches, but realistically, all of the changes have the exact same effect, are reasonably obvious and common. Your new tests also show that they work as expected, without breaking old assumptions (no old tests changed). From that perspective, it looks good to me, but I'll let it simmer for a bit, if someone else has some more comments.

Note: I'm assuming the "IntrNoMem" declaration in some intrinsics have to do with the "HasSideEffects" on the same bundle, but I haven't checked every single instruction to make sure they are strictly correlated.

cheers,
--renato



================
Comment at: test/CodeGen/ARM/smul.ll:294
 }
+
----------------
Is this really necessary?


https://reviews.llvm.org/D32281