[PATCH] D32276: [AsmWriter/APFloat] FP constant printing: Avoid usage of locale dependent snprinf

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 20 01:12:35 PDT 2017


skatkov added inline comments.


================
Comment at: lib/IR/AsmWriter.cpp:1126
         //
         if ((StrVal[0] >= '0' && StrVal[0] <= '9') ||
             ((StrVal[0] == '-' || StrVal[0] == '+') &&
----------------
Do we really need this check? To me it can be safely removed. Does anyone see the reason not to do that?


https://reviews.llvm.org/D32276





More information about the llvm-commits mailing list