[PATCH] D32259: [XRay] [compiler-rt] - Fix standalone build test and XFAIL a test.

[Keith Wyss via llvm-commits]

Fair enough. Shell glob expansion failures exit nonzero and fail the test,
which is why the rm is gated by an if. Find/exec should work without a bash
dependency though.

On Apr 19, 2017 8:10 PM, "Dean Michael Berris via Phabricator" <
reviews at reviews.llvm.org> wrote:

dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM with one nit.



================
Comment at: test/xray/TestCases/Linux/fdr-thread-order.cc:2
 // RUN: %clangxx_xray -g -std=c++11 %s -o %t
-// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false
xray_logfile_base=fdr-thread-order. xray_fdr_log=true verbosity=1" %run %t
2>&1 | FileCheck %s
+// RUN: if compgen -G "fdr-thread-order.*" ; then rm fdr-thread-order.* ;
fi
+// RUN: XRAY_OPTIONS="patch_premain=false xray_naive_log=false
xray_logfile_base=fdr-thread-order. xray_fdr_log=true verbosity=1
xray_fdr_log_func_duration_threshold_us=0" %run %t 2>&1 | FileCheck %s
----------------
I don't think we can make the assumption that bash is the shell, but
unconditionally removing the files anyway would be fine at this point.


https://reviews.llvm.org/D32259
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170419/8cc05287/attachment.html>