[PATCH] D32241: Don't process debug intrinsics in InstCombine
Davide Italiano via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 19 15:44:52 PDT 2017
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
See comment. Also now I think you can probably write a test to make sure the instruction is never inserted in the worklist.
================
Comment at: include/llvm/Transforms/InstCombine/InstCombineWorklist.h:64
for (Instruction *I : reverse(List)) {
- WorklistMap.insert(std::make_pair(I, Idx++));
- Worklist.push_back(I);
+ if (!isa<DbgInfoIntrinsic>(I)) {
+ WorklistMap.insert(std::make_pair(I, Idx++));
----------------
craig.topper wrote:
> Should you skip it when the List being passed in here is being populated?
I'd hoist the insertion in the working list in a separate helper so that we don't have to copy the check in multiple places.
https://reviews.llvm.org/D32241
More information about the llvm-commits
mailing list